Method to import checks from any known extensions #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
From the discussion, we will go for a semi-automated opt-in only approach handled via config files User trusted extensions would be registered via which would add that extension name to the config file such that any subsequent calls would automatically import that module, triggered the import of associated registered checks, without having to call |
|
We also might want to add |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #447 +/- ##
==========================================
- Coverage 87.14% 87.11% -0.03%
==========================================
Files 23 23
Lines 1260 1265 +5
==========================================
+ Hits 1098 1102 +4
- Misses 162 163 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
One idea for removing the need to use
--modules ndx_multichannel_volumeevery timecc @dysprague - can you tell us if this works on your example? (you will probably have to do
pip install git+https://github.com/neurodatawithoutborders/nwbinspector.git@search_for_extension_checks